Re: [PATCH 2/4] perf test: Pass the verbose option to shell tests
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-06-17 19:19:12
Also in:
bpf, lkml
Em Thu, Jun 17, 2021 at 11:42:14AM -0700, Ian Rogers escreveu:
Having a verbose option will allow shell tests to provide extra failure details when the fail or skip.
Thanks, applied to perf/core. - Arnaldo
quoted hunk ↗ jump to hunk
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/tests/builtin-test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index cbbfe48ab802..a8160b1684de 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c@@ -577,11 +577,14 @@ struct shell_test { static int shell_test__run(struct test *test, int subdir __maybe_unused) { int err; - char script[PATH_MAX]; + char script[PATH_MAX + 3]; struct shell_test *st = test->priv; path__join(script, sizeof(script), st->dir, st->file); + if (verbose) + strncat(script, " -v", sizeof(script)); + err = system(script); if (!err) return TEST_OK;-- 2.32.0.288.g62a8d224e6-goog
-- - Arnaldo