Re: [PATCH 1/4] perf test: Fix non-bash issue with stat bpf counters
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-06-17 19:18:38
Also in:
bpf, lkml
Em Thu, Jun 17, 2021 at 11:42:13AM -0700, Ian Rogers escreveu:
$(( .. )) is a bash feature but the test's interpreter is !/bin/sh, switch the code to use expr.
Thanks, applied to perf/urgent. - Arnaldo
quoted hunk ↗ jump to hunk
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/tests/shell/stat_bpf_counters.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/tools/perf/tests/shell/stat_bpf_counters.sh b/tools/perf/tests/shell/stat_bpf_counters.sh index 22eb31e48ca7..2f9948b3d943 100755 --- a/tools/perf/tests/shell/stat_bpf_counters.sh +++ b/tools/perf/tests/shell/stat_bpf_counters.sh@@ -11,9 +11,9 @@ compare_number() second_num=$2 # upper bound is first_num * 110% - upper=$(( $first_num + $first_num / 10 )) + upper=$(expr $first_num + $first_num / 10 ) # lower bound is first_num * 90% - lower=$(( $first_num - $first_num / 10 )) + lower=$(expr $first_num - $first_num / 10 ) if [ $second_num -gt $upper ] || [ $second_num -lt $lower ]; then echo "The difference between $first_num and $second_num are greater than 10%."-- 2.32.0.288.g62a8d224e6-goog
-- - Arnaldo