Re: [PATCH v2 2/4] PCI: brcmstb: Add ACPI config space quirk
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-08-22 08:53:38
Also in:
linux-acpi, linux-arm-kernel, lkml
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-08-22 08:53:38
Also in:
linux-acpi, linux-arm-kernel, lkml
On 8/19/2021 11:56 PM, Jeremy Linton wrote:
The PFTF CM4 is an ACPI platform that isn't ECAM compliant. Its config space is in two parts. One part is for the root port registers and a second moveable window pointing at a device's 4K config space. Thus it doesn't have an MCFG, and any MCFG provided would be nonsense anyway. Instead, a Linux specific host bridge _DSD selects a custom ECAM ops and cfgres. The cfg op picks between those two regions while disallowing problematic accesses. Signed-off-by: Jeremy Linton <redacted>
Once you address Bjorn's feedback, feel free to add: Acked-by: Florian Fainelli <f.fainelli@gmail.com> I do wonder if squashing patches 2 and 3 would make more sense, otherwise we have a bcm2711_pcie_ops that is unused in patch 2. -- Florian