Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-08-02 22:44:27
Also in:
lkml
On Sun, Aug 01, 2021 at 07:55:11PM +0530, Amey Narkhede wrote:
Currently there is separate function pcie_has_flr() to probe if PCIe FLR is supported by the device which does not match the calling convention followed by reset methods which use second function argument to decide whether to probe or not. Add new function pcie_reset_flr() that follows the calling convention of reset methods. Signed-off-by: Amey Narkhede <redacted> --- drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +-- drivers/pci/pci.c | 40 +++++++++++++++------- drivers/pci/pcie/aer.c | 12 +++---- drivers/pci/quirks.c | 9 ++--- include/linux/pci.h | 2 +- 5 files changed, 38 insertions(+), 29 deletions(-)
quoted hunk ↗ jump to hunk
int pcie_flr(struct pci_dev *dev) {@@ -4655,7 +4653,26 @@ int pcie_flr(struct pci_dev *dev) return pci_dev_wait(dev, "FLR", PCIE_RESET_READY_POLL_MS); } -EXPORT_SYMBOL_GPL(pcie_flr); +EXPORT_SYMBOL(pcie_flr);
Why this change? If it's unintentional and there's no other reason to repost, I can fix it up locally.