Thread (8 messages) 8 messages, 3 authors, 2021-08-23

Re: [PATCH] nvme-tcp: Do not reset transport on data digest errors

From: Hannes Reinecke <hare@suse.de>
Date: 2021-08-20 10:20:57
Also in: lkml

On 8/5/21 2:15 PM, Daniel Wagner wrote:
The spec says

   7.4.6.1 Digest Error handling

   When a host detects a data digest error in a C2HData PDU, that host
   shall continue processing C2HData PDUs associated with the command and
   when the command processing has completed, if a successful status was
   returned by the controller, the host shall fail the command with a
   non-fatal transport error.

Currently the transport is reseted when a data digest error is
detected. To fix this, keep track of the final status in the queue
object and use it when completing the request.

The new member can be placed adjacent to the receive related members and
fits in the cacheline as there is a 4 byte hole.

Signed-off-by: Daniel Wagner <redacted>
---
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help