Thread (8 messages) 8 messages, 3 authors, 2021-08-23

Re: [PATCH] nvme-tcp: Do not reset transport on data digest errors

From: Daniel Wagner <hidden>
Date: 2021-08-09 09:09:54
Also in: lkml

Hi Sagi,

On Fri, Aug 06, 2021 at 12:42:00PM -0700, Sagi Grimberg wrote:
quoted
@@ -89,6 +89,7 @@ struct nvme_tcp_queue {
  	size_t			data_remaining;
  	size_t			ddgst_remaining;
  	unsigned int		nr_cqe;
+	u16			status;
Why is this a queue member and not a request member?
I was not sure if the TCP transport specific error handling should
impact all other transport (size of struct request). Also I tried to
avoid accessing cachelines which are not already in use. Except this I
don't see there should be no problem to put this to struct request.

Daniel

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help