Re: [PATCH] nvme-pci: set some AMD PCIe downstream storage device to D3 for s2idle
From: Christoph Hellwig <hch@lst.de>
Date: 2021-05-25 06:22:08
On Tue, May 25, 2021 at 10:48:59AM +0800, Prike Liang wrote:
quoted hunk ↗ jump to hunk
+#ifdef CONFIG_X86 +#include <asm/cpu_device_id.h> +#endif #include "trace.h" #include "nvme.h"@@ -2828,6 +2831,16 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) } #ifdef CONFIG_ACPI + +#ifdef CONFIG_X86 +static const struct x86_cpu_id storage_d3_cpu_ids[] = { + X86_MATCH_VENDOR_FAM_MODEL(AMD, 25, 80, NULL), /*Cezanne*/ + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /*Renoir*/ + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL),/*Lucienne*/ + {} +}; +#endif
This is completely unacceptable. The NVMe driver could not care less what CPU we on. We need information from the PCI or power managment core on how broken the power management of the root port is, not this kind of crap in a low-level driver, with potentially many more needing the same kind of quirk in the future. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme