I submitted new patch that addressing the below issues

http://lists.infradead.org/pipermail/linux-nvme/2021-March/023824.html

Elad


-----Original Message-----
From: Hou Pu <redacted> 
Sent: Wednesday, 17 March 2021 6:11
To: Grupi, Elad
Cc: linux-nvme@lists.infradead.org; sagi@grimberg.me
Subject: Re: [PATCH] nvme-tcp: fix a segmentation fault during io parsing error


[EXTERNAL EMAIL] 


On 2021/3/16 11:52, Grupi, Elad wrote:

Hi Hou,

You are correct, this is the same issue.

I have reviewed your patch and I have two concerns:
1. As Sagi mentioned, you might not have all the inline data in the socket at this point.
2. You might get hit on the last round of the budget of the receive loop, so you will still have a chance of hitting the response flow before reading all the data from the socket.

Yes, I realize my patch has these problems.

Thanks,

Hou

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme