This was a silly typo, did you check if it addressed your issue when you applied the needed change?

Yes. We applied the needed change before testing your patch, but still had kernel panic on recv flow when we had unread inline data on the socket.

There are stuff there that I think we need to use for sorting out other issues where your bug report is the trigger for this.

I agree, changes looks good. 

-----Original Message-----
From: Sagi Grimberg <sagi@grimberg.me> 
Sent: Thursday, 14 January 2021 23:18
To: Grupi, Elad; linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-tcp: fix a segmentation fault during io parsing error


[EXTERNAL EMAIL] 

Thank you Sagi,

I will submit a new patch with a comment as requested.

Thanks.

The patch you sent did not solve that issue, I submitted some comments on the relevant thread.

This was a silly typo, did you check if it addressed your issue when you applied the needed change?

There are stuff there that I think we need to use for sorting out other issues where your bug report is the trigger for this.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme