Re: [PATCH 4/4] nvme-fc: return NVME_SC_HOST_ABORTED_CMD when a command has been aborted
From: James Smart <hidden>
Date: 2021-03-01 19:08:00
On 2/25/2021 11:17 PM, Hannes Reinecke wrote:
quoted hunk ↗ jump to hunk
When a command has been aborted we should return NVME_SC_HOST_ABORTED_CMD to be consistent with the other transports. Cc: James Smart <redacted> Signed-off-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Daniel Wagner <redacted> --- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index ef12a619daec..97e3424c7b03 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c@@ -1956,7 +1956,7 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req) sizeof(op->rsp_iu), DMA_FROM_DEVICE); if (opstate == FCPOP_STATE_ABORTED) - status = cpu_to_le16(NVME_SC_HOST_PATH_ERROR << 1); + status = cpu_to_le16(NVME_SC_HOST_ABORTED_CMD << 1); else if (freq->status) { status = cpu_to_le16(NVME_SC_HOST_PATH_ERROR << 1); dev_info(ctrl->ctrl.device,
Is there a difference between an I/O aborted by a NVME ABORT cmd vs a transport-cancelled io ? This line is more the transport-cancelled io. -- james _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme