Thread (11 messages) 11 messages, 2 authors, 2021-01-31

Re: [PATCH] nvme-tcp: proper handling of tcp socket closing flows

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-01-29 22:10:35

quoted hunk ↗ jump to hunk
@@ -1453,9 +1453,27 @@ static int nvmet_tcp_set_queue_sock(struct nvmet_tcp_queue *queue)
  	sock->sk->sk_state_change = nvmet_tcp_state_change;
  	queue->write_space = sock->sk->sk_write_space;
  	sock->sk->sk_write_space = nvmet_tcp_write_space;
+
+	switch (sk->sk_state) {
+	case TCP_FIN_WAIT1:
+	case TCP_CLOSE_WAIT:
+	case TCP_CLOSE:
BTW, shouldn't this be if (sk->sk_state != TCP_ESTABLISHED) ?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help