Re: [PATCH V3 3/3] nvme: retry commands based on ACRE flag
From: Keith Busch <kbusch@kernel.org>
Date: 2021-01-15 17:04:45
On Thu, Jan 14, 2021 at 10:31:10PM +0900, Minwoo Im wrote:
quoted hunk ↗ jump to hunk
@@ -317,6 +316,13 @@ static inline enum nvme_disposition nvme_decide_disposition(struct request *req) return COMPLETE; } + if (nvme_req(req)->ctrl->acre && + !nvme_is_path_error(nvme_req(req)->status) && + !blk_queue_dying(req->q)) + return RETRY;
Is there really any reason to tie this to acre?
+ else if (blk_noretry_request(req)) + return COMPLETE;
I am not sure we should ignore the FAILFAST for non-path errors. If we need retryable admin commands, we should let the driver provide a way for callers to dispatch requests without that flag. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme