On May 15, 2023, at 12:56 PM, Jeff Layton [off-list ref] wrote:

On Mon, 2023-05-15 at 09:32 -0400, Chuck Lever wrote:

quoted

This series updates observability around socket creation and
destruction to help troubleshoot issues such as:

https://lore.kernel.org/linux-nfs/65AFD2EF-E5D3-4461-B23A-D294486D5F65@oracle.com/T/#t (local)

I plan to apply these to nfsd-next.

---

Chuck Lever (4):
     SUNRPC: Fix an incorrect comment
     SUNRPC: Remove dprintk() in svc_handle_xprt()
     SUNRPC: Improve observability in svc_tcp_accept()
     SUNRPC: Trace struct svc_sock lifetime events


include/trace/events/sunrpc.h | 39 ++++++++++++++++++++++++-----------
net/sunrpc/svc_xprt.c         |  3 ---
net/sunrpc/svcsock.c          | 15 ++++++--------
3 files changed, 33 insertions(+), 24 deletions(-)

--
Chuck Lever

These all look fine to me. I had one nit about a conditional tracepoint,
but your call on whether you want to respin it that way.

Great minds, and all that... I had considered it, but decided
it wasn't worth bothering. I appreciate your time and comments!

Reviewed-by: Jeff Layton <jlayton@kernel.org>

--
Chuck Lever