Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()

[PATCH v1 00/12] lib/string_helpers: get rid of ugly *_escape_mem_ascii() API · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 02/12] lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a loop · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 04/12] lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and non-printable · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 03/12] lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 01/12] lib/string_helpers: Switch to use BIT() macro · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 08/12] lib/test-string_helpers: Get rid of trailing comma in terminators · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 07/12] lib/test-string_helpers: Print flags in hexadecimal format · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 06/12] lib/string_helpers: Allow to append additional characters to be escaped · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 11/12] lib/string_helpers: Drop unused *_escape_mem_ascii() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 12/12] MAINTAINERS: Add myself as designated reviewer for generic string library · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 09/12] lib/test-string_helpers: Add test cases for new features · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 05/12] lib/string_helpers: Drop indentation level in string_escape_mem() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Al Viro <viro@zeniv.linux.org.uk> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Al Viro <viro@zeniv.linux.org.uk> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03

From: Andy Shevchenko <hidden>
Date: 2021-05-03 21:14:26
Also in: linux-fsdevel, lkml

On Tue, May 4, 2021 at 12:11 AM Andy Shevchenko
[off-list ref] wrote:

On Tue, May 4, 2021 at 12:09 AM Al Viro [off-list ref] wrote:

quoted

On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote:

quoted

On Mon, May 3, 2021 at 11:54 PM Al Viro [off-list ref] wrote:

...

quoted

Any suggestions how to replace that API with a newer one?

seq_escape_mem(), perhaps?

I think I have a better idea. What about adding seq_escape_with_flags()
and seq_escape() --> seq_escape_with_flags(..., ESCAPE_OCTAL, ...) ?

Would it work for you?

Ah, it wouldn't work for the user, because it wants to pass the buffer size.
Okay, I'll take your suggestion, thanks!

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help