Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()

[PATCH v1 00/12] lib/string_helpers: get rid of ugly *_escape_mem_ascii() API · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 02/12] lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a loop · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 04/12] lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and non-printable · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 03/12] lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 01/12] lib/string_helpers: Switch to use BIT() macro · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 08/12] lib/test-string_helpers: Get rid of trailing comma in terminators · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 07/12] lib/test-string_helpers: Print flags in hexadecimal format · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 06/12] lib/string_helpers: Allow to append additional characters to be escaped · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 11/12] lib/string_helpers: Drop unused *_escape_mem_ascii() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 12/12] MAINTAINERS: Add myself as designated reviewer for generic string library · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 09/12] lib/test-string_helpers: Add test cases for new features · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 05/12] lib/string_helpers: Drop indentation level in string_escape_mem() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
[PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Al Viro <viro@zeniv.linux.org.uk> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Al Viro <viro@zeniv.linux.org.uk> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03
Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem() · Andy Shevchenko <hidden> · 2021-05-03

From: Andy Shevchenko <hidden>
Date: 2021-05-03 20:57:00
Also in: linux-fsdevel, lkml

On Mon, May 3, 2021 at 11:54 PM Al Viro [off-list ref] wrote:

On Mon, May 03, 2021 at 11:49:05PM +0300, Andy Shevchenko wrote:

quoted

string_escape_mem_ascii() followed by seq_escape_mem_ascii() is completely
non-flexible and shouldn't be exist from day 1.

Replace it with properly called string_escape_mem().

NAKed-by: Al Viro [off-list ref]

Reason: use of seq_get_buf().  Which should have been static inline in
fs/seq_file.c, to start with.

I see.

Again, any new uses of seq_get_buf()/seq_commit() are grounds for automatic
NAK.  These interfaces *will* be withdrawn.

You meant that this is no way to get rid of this guy?
Any suggestions how to replace that API with a newer one?


-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help