Re: linux-next: build failure after merge of the akpm tree
From: Takashi Iwai <hidden>
Date: 2016-01-25 11:04:00
Also in:
lkml
On Mon, 25 Jan 2016 11:45:56 +0100, Sudip Mukherjee wrote:
On Mon, Jan 25, 2016 at 10:29:54AM +0100, Takashi Iwai wrote:quoted
On Fri, 22 Jan 2016 03:40:45 +0100, Stephen Rothwell wrote:quoted
Hi all, On Fri, 22 Jan 2016 11:24:42 +1100 Stephen Rothwell [off-list ref] wrote:quoted
On Thu, 21 Jan 2016 07:38:59 +1100 Stephen Rothwell [off-list ref] wrote:quoted
On Wed, 20 Jan 2016 15:09:47 +0100 Takashi Iwai [off-list ref] wrote:quoted
On Sat, 16 Jan 2016 09:51:29 +0100, Takashi Iwai wrote:quoted
There are a few ways to fix this, but all are not comfortable. A. Disable compress API for powerpc.This also affects alpha, mips and (maybe) sparc.This was exposed on PowerPC by commit bf76f73c5f65 ("powerpc: enable UBSAN support") which is in Linus' tree as of this morning. The only relevant change that made was in the compiler flags (I tested this by building the file without that commit but with these new compiler flags: -fsanitize=shift -fsanitize=integer-divide-by-zero -fsanitize=unreachable -fsanitize=vla-bound -fsanitize=null -fsanitize=signed-integer-overflow -fsanitize=bounds -fsanitize=object-size -fsanitize=returns-nonnull-attribute -fsanitize=bool -fsanitize=enum -fsanitize=alignment The preprocessed file is the same in both cases, but with these flags the compiler errors.So for now I have suppressed the error using the following patch (which I will keep in my fixes tree until some other fix is applied): From: Stephen Rothwell <redacted> Date: Fri, 22 Jan 2016 13:24:57 +1100 Subject: [PATCH] next: suppress the building of all the sound codecs on PPC for now Signed-off-by: Stephen Rothwell <redacted> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 50693c867e71..ee5f36b9c787 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig@@ -13,6 +13,7 @@ menu "CODEC drivers" config SND_SOC_ALL_CODECS tristate "Build all ASoC CODEC drivers" depends on COMPILE_TEST + depends on !PPC select SND_SOC_88PM860X if MFD_88PM860X select SND_SOC_L3 select SND_SOC_AB8500_CODEC if ABX500_CORESuppressing this whole is an overreaction, IMO. It should suffice just to disable compile-testing Intel driver. How about the patch below? thanks, Takashi -- 8< -- From: Takashi Iwai <redacted> Subject: [PATCH] ASoC: intel: suppress compile-test with PowerPC Since some ioctl in compress offload API is broken for PPC (the struct size overflows), now we get actually the build error. Until we get the proper solution (e.g. alternative ioctl), let's disable the build of Intel ASoC driver that is the only driver who enables SND_SOC_COMPRESS (and eventually SND_COMPRESS_OFFLOAD) in the mainline tree.Sorry, but this does not fix the build failure. I can still see SND_COMPRESS_OFFLOAD=m in .config and the build fails.
Who sets this config? SND_COMPRESS_OFFLOAD has no prompt, so this should be default off.
quoted hunk ↗ jump to hunk
But the following does fix it for powerpc:diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig index 7ea66ee..b92d286 100644 --- a/sound/soc/Kconfig +++ b/sound/soc/Kconfig@@ -31,6 +31,7 @@ config SND_SOC_GENERIC_DMAENGINE_PCM config SND_SOC_COMPRESS bool + depends on !PPC select SND_COMPRESS_OFFLOAD config SND_SOC_TOPOLOGY
It has a reverse-selection, and the reverse-selection ignores Depends, AFAIK. If that long-standing problem were already fixed, it's great... Takashi
-- I will just check with alpha and see if that is also affected. regards sudip