Thread (28 messages) 28 messages, 7 authors, 2016-01-26

Re: linux-next: build failure after merge of the akpm tree

From: Takashi Iwai <hidden>
Date: 2016-01-25 09:30:08
Also in: lkml
Subsystem: intel asoc drivers, sound, sound - soc layer / dynamic audio power management (asoc), the rest · Maintainers: Cezary Rojewski, Liam Girdwood, Peter Ujfalusi, Bard Liao, Kai Vehmanen, Jaroslav Kysela, Takashi Iwai, Mark Brown, Linus Torvalds

On Fri, 22 Jan 2016 03:40:45 +0100,
Stephen Rothwell wrote:
quoted hunk ↗ jump to hunk
Hi all,

On Fri, 22 Jan 2016 11:24:42 +1100 Stephen Rothwell [off-list ref] wrote:
quoted
On Thu, 21 Jan 2016 07:38:59 +1100 Stephen Rothwell [off-list ref] wrote:
quoted
On Wed, 20 Jan 2016 15:09:47 +0100 Takashi Iwai [off-list ref] wrote:  
quoted
On Sat, 16 Jan 2016 09:51:29 +0100,
Takashi Iwai wrote:    
quoted
There are a few ways to fix this, but all are not comfortable.

A. Disable compress API for powerpc.    
This also affects alpha, mips and (maybe) sparc.  
This was exposed on PowerPC by commit bf76f73c5f65 ("powerpc: enable
UBSAN support") which is in Linus' tree as of this morning.  The only
relevant change that made was in the compiler flags (I tested this by
building the file without that commit but with these new compiler flags:

-fsanitize=shift -fsanitize=integer-divide-by-zero
-fsanitize=unreachable -fsanitize=vla-bound -fsanitize=null
-fsanitize=signed-integer-overflow -fsanitize=bounds
-fsanitize=object-size -fsanitize=returns-nonnull-attribute
-fsanitize=bool -fsanitize=enum -fsanitize=alignment

The preprocessed file is the same in both cases, but with these flags
the compiler errors.
So for now I have suppressed the error using the following patch (which
I will keep in my fixes tree until some other fix is applied):

From: Stephen Rothwell <redacted>
Date: Fri, 22 Jan 2016 13:24:57 +1100
Subject: [PATCH] next: suppress the building of all the sound codecs on PPC
 for now

Signed-off-by: Stephen Rothwell <redacted>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 50693c867e71..ee5f36b9c787 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -13,6 +13,7 @@ menu "CODEC drivers"
 config SND_SOC_ALL_CODECS
 	tristate "Build all ASoC CODEC drivers"
 	depends on COMPILE_TEST
+	depends on !PPC
 	select SND_SOC_88PM860X if MFD_88PM860X
 	select SND_SOC_L3
 	select SND_SOC_AB8500_CODEC if ABX500_CORE
Suppressing this whole is an overreaction, IMO.  It should suffice
just to disable compile-testing Intel driver.
How about the patch below?


thanks,

Takashi

-- 8< --
From: Takashi Iwai <redacted>
Subject: [PATCH] ASoC: intel: suppress compile-test with PowerPC

Since some ioctl in compress offload API is broken for PPC (the struct
size overflows), now we get actually the build error.

Until we get the proper solution (e.g. alternative ioctl), let's
disable the build of Intel ASoC driver that is the only driver who
enables SND_SOC_COMPRESS (and eventually SND_COMPRESS_OFFLOAD) in the
mainline tree.

Signed-off-by: Takashi Iwai <redacted>
---
 sound/soc/intel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 803f95e40679..d854cd66e090 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -31,6 +31,8 @@ config SND_SOC_INTEL_SST
 	tristate
 	select SND_SOC_INTEL_SST_ACPI if ACPI
 	depends on (X86 || COMPILE_TEST)
+	# FIXME: a part of compress API is broken for PPC
+	depends on !PPC
 
 config SND_SOC_INTEL_SST_ACPI
 	tristate
-- 
2.7.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help