RE: [Intel-wired-lan] [PATCH 13/61] squashfs: Prefer IS_ERR_OR_NULL over manual NULL check

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf
Of Philipp Hahn
Sent: Tuesday, March 10, 2026 12:49 PM
To: amd-gfx@lists.freedesktop.org; apparmor@lists.ubuntu.com;
bpf@vger.kernel.org; ceph-devel@vger.kernel.org; cocci@inria.fr; dm-
devel@lists.linux.dev; dri-devel@lists.freedesktop.org;
gfs2@lists.linux.dev; intel-gfx@lists.freedesktop.org; intel-wired-
lan@lists.osuosl.org; iommu@lists.linux.dev; kvm@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-block@vger.kernel.org;
linux-bluetooth@vger.kernel.org; linux-btrfs@vger.kernel.org; linux-
cifs@vger.kernel.org; linux-clk@vger.kernel.org; linux-
erofs@lists.ozlabs.org; linux-ext4@vger.kernel.org; linux-
fsdevel@vger.kernel.org; linux-gpio@vger.kernel.org; linux-
hyperv@vger.kernel.org; linux-input@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-leds@vger.kernel.org; linux-
media@vger.kernel.org; linux-mips@vger.kernel.org; linux-mm@kvack.org;
linux-modules@vger.kernel.org; linux-mtd@lists.infradead.org; linux-
nfs@vger.kernel.org; linux-omap@vger.kernel.org; linux-
phy@lists.infradead.org; linux-pm@vger.kernel.org; linux-
rockchip@lists.infradead.org; linux-s390@vger.kernel.org; linux-
scsi@vger.kernel.org; linux-sctp@vger.kernel.org; linux-security-
module@vger.kernel.org; linux-sh@vger.kernel.org; linux-
sound@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
linux-trace-kernel@vger.kernel.org; linux-usb@vger.kernel.org; linux-
wireless@vger.kernel.org; netdev@vger.kernel.org;
ntfs3@lists.linux.dev; samba-technical@lists.samba.org; sched-
ext@lists.linux.dev; target-devel@vger.kernel.org; tipc-
discussion@lists.sourceforge.net; v9fs@lists.linux.dev; Philipp Hahn
[off-list ref]
Cc: Phillip Lougher <phillip@squashfs.org.uk>
Subject: [Intel-wired-lan] [PATCH 13/61] squashfs: Prefer
IS_ERR_OR_NULL over manual NULL check

Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL
check.

Change generated with coccinelle.

To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Philipp Hahn <redacted>
---
 fs/squashfs/cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/squashfs/cache.c b/fs/squashfs/cache.c index

67abd4dff222235e75d8c2b10d5e9b811d6e38d8..8888cc02966e2e33210c872c7332
05d4c581ecc9 100644

--- a/fs/squashfs/cache.c
+++ b/fs/squashfs/cache.c

@@ -198,7 +198,7 @@ void squashfs_cache_delete(struct squashfs_cache

*cache)  {
 	int i, j;

-	if (IS_ERR(cache) || cache == NULL)
+	if (IS_ERR_OR_NULL(cache))
 		return;

 	for (i = 0; i < cache->entries; i++) {

--
2.43.0