Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

From
Masahiro Yamada <masahiroy@kernel.org>
Date
2025-06-02 18:00:45
Also in
linux-kbuild, lkml
Reply to
Alexey Gladkov, 2025-06-02
On Mon, Jun 2, 2025 at 5:24 PM Alexey Gladkov [off-list ref] wrote:
On Mon, Jun 02, 2025 at 04:52:36PM +0900, Masahiro Yamada wrote:
quoted
On Tue, May 27, 2025 at 6:08 PM Alexey Gladkov [off-list ref] wrote:
quoted
In order to avoid symbol conflicts if they appear in the same binary, a
more unique alias identifier can be generated.

Signed-off-by: Alexey Gladkov <legion@kernel.org>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
---
 include/linux/module.h   | 14 ++++++++++++--
 scripts/mod/file2alias.c | 18 ++++++++++++++----
 2 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 88048561360f..e7506684069d 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -249,10 +249,20 @@ struct module_kobject *lookup_or_create_module_kobject(const char *name);
 /* What your module does. */
 #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description)

+/* Format: __mod_device_table__<counter>__kmod_<modname>__<type>__<name> */
This format relies on module-name mangling, but
I hope we will be able to stop doing it some day.
I didn't like this approach either when I found out how it was
implemented.
Yeah, I dislike it.

I hope we can stop this historical mistake:
https://lore.kernel.org/lkml/20250602130609.402581-1-masahiroy@kernel.org/ (local)

Once we stop doing that, __KBUILD_MODNAME will not match to KBUILD_MODNAME.


Also, you need to be careful about the rust side, as
you did not take care of it.

https://github.com/torvalds/linux/blob/v6.15/rust/kernel/device_id.rs#L157



We can only add the module name to the structure to which the alias is
made. But the problem with this is that right now there is no common
structure for DEVICE_TABLE. Each module comes up with its own.

It is possible to add a common structure, but that would be a big
refactoring.



-- 
Best Regards
Masahiro Yamada
Thread (31 messages) 31 messages, 3 authors, last reply 2025-06-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help