Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

From
Alexey Gladkov <legion@kernel.org>
Date
2025-06-02 14:04:00
Also in
linux-kbuild, lkml
Reply to
Masahiro Yamada, 2025-06-02
On Mon, Jun 02, 2025 at 07:58:41PM +0900, Masahiro Yamada wrote:
On Mon, Jun 2, 2025 at 5:07 PM Alexey Gladkov [off-list ref] wrote:
quoted
On Mon, Jun 02, 2025 at 04:45:36PM +0900, Masahiro Yamada wrote:
quoted
On Tue, May 27, 2025 at 6:08 PM Alexey Gladkov [off-list ref] wrote:
quoted
In order to avoid symbol conflicts if they appear in the same binary, a
more unique alias identifier can be generated.
Why must this be unique?

What problem would happen if the same symbol names
appear in MODULE_DEVICE_TABLE()?
Before these patches this was not a problem as non-unique characters are
in separate object files when the module is compiled separately.

But when the modules are compiled into the kernel, there is a symbol
conflict when linking vmlinuz. We have modules that export multiple device
tables from different object files.
This is because the __mod_device_table__* symbols are global, but
I suspect they do not need to be.

Let's test this
https://lore.kernel.org/lkml/20250602105539.392362-1-masahiroy@kernel.org/T/#u (local)
I tested this patch with the config:

make allmodconfig
make mod2yesconfig

and it works.

-- 
Rgrds, legion
Thread (31 messages) 31 messages, 3 authors, last reply 2025-06-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help