Thread (36 messages) flat view 36 messages, 14 authors, 2023-04-05

Re: [PATCH 13/20] reset: remove MODULE_LICENSE in non-modules

From: Conor Dooley <conor@kernel.org>
Date: 2023-02-28 19:17:50
Also in: linux-riscv, lkml

On Tue, Feb 28, 2023 at 01:02:08PM +0000, Nick Alcock wrote:
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Conor Dooley <conor.dooley@microchip.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-riscv@lists.infradead.org
---
 drivers/reset/reset-mpfs.c | 1 -
I assume your script just got confused here w/ $subject, since there's
only a change for this specific file.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help