RE: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2023-02-28 16:35:53
Also in:
lkml
-----Original Message-----
From: Nick Alcock <redacted>
Sent: Tuesday, February 28, 2023 5:02 AM
To: mcgrof@kernel.org
Cc: linux-modules@vger.kernel.org; linux-kernel@vger.kernel.org; Hitomi
Hasegawa [off-list ref]; Keller, Jacob E
[off-list ref]
Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <redacted>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>Acked-by: Jacob Keller <jacob.e.keller@intel.com>
quoted hunk ↗ jump to hunk
--- lib/pldmfw/pldmfw.c | 1 - 1 file changed, 1 deletion(-)diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c index 6e77eb6d8e72e..54e1809a38fd9 100644 --- a/lib/pldmfw/pldmfw.c +++ b/lib/pldmfw/pldmfw.c@@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, conststruct firmware *fw) EXPORT_SYMBOL(pldmfw_flash_image); MODULE_AUTHOR("Jacob Keller [off-list ref]"); -MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("PLDM firmware flash update library"); -- 2.39.1.268.g9de2f9a303