Re: [PATCH 4/4] depmod: Add error message for bad version
From: Lucas De Marchi <hidden>
Date: 2015-09-12 19:00:55
From: Lucas De Marchi <hidden>
Date: 2015-09-12 19:00:55
On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott [off-list ref] wrote:
Currently, if a value that doesn't match a kernel version
("%u.%u") is passed in, depmod silently falls back to
using uname. Make it clear to the user that this is happening
by giving a message to the user.
---Actually I think we should not fallback. If the user passed a wrong number, fallbacking to the currently running kernel is plain wrong. This was done mostly due to compatibility with module-init-tools but I prefer breaking it rather than silently (or verbose as per your patch) doing the wrong thing. thanks Lucas De Marchi