Re: [PATCH 4/4] depmod: Add error message for bad version
From: Lucas De Marchi <hidden>
Date: 2015-09-24 01:17:12
From: Lucas De Marchi <hidden>
Date: 2015-09-24 01:17:12
On Fri, Sep 18, 2015 at 3:30 PM, Laura Abbott [off-list ref] wrote:
On 09/12/2015 12:00 PM, Lucas De Marchi wrote:quoted
On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott [off-list ref] wrote:quoted
Currently, if a value that doesn't match a kernel version ("%u.%u") is passed in, depmod silently falls back to using uname. Make it clear to the user that this is happening by giving a message to the user. ---Actually I think we should not fallback. If the user passed a wrong number, fallbacking to the currently running kernel is plain wrong. This was done mostly due to compatibility with module-init-tools but I prefer breaking it rather than silently (or verbose as per your patch) doing the wrong thing.Sounds fine to me if you are okay with the breakage.
yep thanks Lucas De Marchi