Re: [RFC PATCH v2 07/21] dt-bindings: mmc: renesas,sdhi: add optional SDnH clock
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-11-12 11:10:45
Also in:
linux-devicetree, linux-renesas-soc
Hi Wolfram, CC devicetree On Wed, Nov 10, 2021 at 8:16 PM Wolfram Sang [off-list ref] wrote:
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since RFC v1: * use 'oneOf' for the clock-names
Thanks for the update!
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml@@ -132,12 +132,20 @@ allOf: properties: clocks: minItems: 1 - maxItems: 2 + maxItems: 3 clock-names: - minItems: 1 - items: + oneOf: - const: core - - const: cd + - items: + - const: core + - const: cd + - items: + - const: core + - const: clkh + - items: + - const: core + - const: clkh + - const: cd
That can be simplified to:
clock-names:
minItems: 1
maxItems: 3
uniqueItems: true
items:
- const: core
- enum: [ clkh, cd ]
- const: cd
But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds