Re: [PATCH v3 6/8] dm: add add_disk() error handling
From: Hannes Reinecke <hare@suse.de>
Date: 2021-09-06 06:19:05
Also in:
dm-devel, linux-block, linux-nvme, linux-scsi, lkml
From: Hannes Reinecke <hare@suse.de>
Date: 2021-09-06 06:19:05
Also in:
dm-devel, linux-block, linux-nvme, linux-scsi, lkml
On 8/30/21 11:25 PM, Luis Chamberlain wrote:
We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. There are two calls to dm_setup_md_queue() which can fail then, one on dm_early_create() and we can easily see that the error path there calls dm_destroy in the error path. The other use case is on the ioctl table_load case. If that fails userspace needs to call the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other failure. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/md/dm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer