Re: [PATCH 07/10] md: add error handling support for add_disk()

[PATCH 00/10] block: first batch of add_disk() error handling conversions · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
[PATCH 02/10] scsi/sd: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 02/10] scsi/sd: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
[PATCH 09/10] loop: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 09/10] loop: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
[PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-27
Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-28
[PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
Re: [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-27
[PATCH 05/10] nvme: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 05/10] nvme: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
Re: [PATCH 05/10] nvme: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-27
[PATCH 06/10] mmc/core/block: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 06/10] mmc/core/block: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
Re: [PATCH 06/10] mmc/core/block: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-27
Re: [PATCH 06/10] mmc/core/block: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-28
Re: [PATCH 06/10] mmc/core/block: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-30
[PATCH 08/10] dm: add add_disk() error handling · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 08/10] dm: add add_disk() error handling · Christoph Hellwig <hch@infradead.org> · 2021-08-24
Re: [PATCH 08/10] dm: add add_disk() error handling · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-27
Re: [PATCH 08/10] dm: add add_disk() error handling · Christoph Hellwig <hch@infradead.org> · 2021-08-28
Re: [PATCH 08/10] dm: add add_disk() error handling · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-30
[PATCH 04/10] scsi/sr: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 04/10] scsi/sr: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
[PATCH 07/10] md: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 07/10] md: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24
[PATCH 10/10] nbd: add error handling support for add_disk() · Luis Chamberlain <mcgrof@kernel.org> · 2021-08-23
Re: [PATCH 10/10] nbd: add error handling support for add_disk() · Christoph Hellwig <hch@infradead.org> · 2021-08-24

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-08-24 06:18:45
Also in: dm-devel, linux-block, linux-nvme, linux-scsi, lkml

On Mon, Aug 23, 2021 at 01:29:27PM -0700, Luis Chamberlain wrote:

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

We just do the unwinding of what was not done before, and are
sure to unlock prior to bailing.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help