Re: [PATCH 05/10] nvme: add error handling support for add_disk()
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-08-24 06:13:38
Also in:
dm-devel, linux-block, linux-nvme, linux-scsi, lkml
On Mon, Aug 23, 2021 at 01:29:25PM -0700, Luis Chamberlain wrote:
quoted hunk ↗ jump to hunk
+ rc = device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups); + if (rc) + goto out_cleanup_ns_from_list; +
Nit: no real need for the rc variable here as we never use the actual value.
quoted hunk ↗ jump to hunk
if (!nvme_ns_head_multipath(ns->head)) nvme_add_ns_cdev(ns);@@ -3785,6 +3789,10 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid, return; + out_cleanup_ns_from_list: + down_write(&ctrl->namespaces_rwsem); + list_del_init(&ns->list); + up_write(&ctrl->namespaces_rwsem);
This also needs to do a nvme_put_ctrl.