Re: [PATCH 01/11] mmc: core: Drop open coding when preparing commands with... | linux-mmc

[PATCH 00/11] Initital support for new power/perf features for SD cards · Ulf Hansson <hidden> · 2021-05-04
[PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 03/11] mmc: core: Re-structure some code in __mmc_poll_for_busy() · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 03/11] mmc: core: Re-structure some code in __mmc_poll_for_busy() · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 03/11] mmc: core: Re-structure some code in __mmc_poll_for_busy() · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 05/11] mmc: core: Enable eMMC sleep commands to use HW busy polling · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 05/11] mmc: core: Enable eMMC sleep commands to use HW busy polling · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 05/11] mmc: core: Enable eMMC sleep commands to use HW busy polling · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds · Ulf Hansson <hidden> · 2021-05-07
Re: [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 08/11] mmc: core: Parse the SD SCR register for support of CMD48/49 and CMD58/59 · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 08/11] mmc: core: Parse the SD SCR register for support of CMD48/49 and CMD58/59 · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 08/11] mmc: core: Parse the SD SCR register for support of CMD48/49 and CMD58/59 · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
[PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Linus Walleij <hidden> · 2021-05-06
Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Ulf Hansson <hidden> · 2021-05-07
Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Shawn Lin <shawn.lin@rock-chips.com> · 2021-05-07
Re: [PATCH 09/11] mmc: core: Read the SD function extension registers for power management · Ulf Hansson <hidden> · 2021-05-07
[PATCH 10/11] mmc: core: Read performance enhancements registers for SD cards · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 10/11] mmc: core: Read performance enhancements registers for SD cards · Linus Walleij <hidden> · 2021-05-06
[PATCH 11/11] mmc: core: Add support for Power Off Notification for SD cards · Ulf Hansson <hidden> · 2021-05-04
Re: [PATCH 11/11] mmc: core: Add support for Power Off Notification for SD cards · Linus Walleij <hidden> · 2021-05-06
RE: [PATCH 00/11] Initital support for new power/perf features for SD cards · Avri Altman <Avri.Altman@wdc.com> · 2021-05-07
Re: [PATCH 00/11] Initital support for new power/perf features for SD cards · Ulf Hansson <hidden> · 2021-05-07
Re: [PATCH 00/11] Initital support for new power/perf features for SD cards · Ulf Hansson <hidden> · 2021-05-11

Re: [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling

From: Linus Walleij <hidden>
Date: 2021-05-06 12:50:34
Also in: linux-block, lkml

On Tue, May 4, 2021 at 6:12 PM Ulf Hansson [off-list ref] wrote:

Similar code for validating the host->max_busy_timeout towards the current
command's busy timeout, exists in mmc_do_erase(), mmc_sleep() and
__mmc_switch(). Let's move the common code into a helper function.

Signed-off-by: Ulf Hansson <redacted>

This is a really nice refactoring in its own right.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help