Thread (41 messages) 41 messages, 4 authors, 2021-11-17

Re: [RFC PATCH 21/32] mm: Convert struct page to struct slab in functions used by other subsystems

From: Vlastimil Babka <hidden>
Date: 2021-11-16 23:38:24
Also in: cgroups

On 11/17/2021 12:04 AM, Andrey Konovalov wrote:
On Tue, Nov 16, 2021 at 5:33 PM Vlastimil Babka [off-list ref] wrote:
quoted
On 11/16/21 15:02, Andrey Konovalov wrote:
quoted
quoted
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -249,7 +249,7 @@ static void print_address_description(void *addr, u8 tag)

        if (page && PageSlab(page)) {
                struct kmem_cache *cache = page->slab_cache;
-               void *object = nearest_obj(cache, page, addr);
+               void *object = nearest_obj(cache, page_slab(page),      addr);
The tab before addr should be a space. checkpatch should probably report this.
Good catch, thanks. Note the tab is there already before this patch, it just
happened to appear identical to a single space before.
Ah, indeed. Free free to keep this as is to not pollute the patch. Thanks!
I will fix it up in patch 24/32 so that this one can stay purely autogenerated
and there's no extra pre-patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help