Thread (41 messages) 41 messages, 4 authors, 2021-11-17

Re: [RFC PATCH 21/32] mm: Convert struct page to struct slab in functions used by other subsystems

From: Andrey Konovalov <andreyknvl@gmail.com>
Date: 2021-11-16 23:05:20
Also in: cgroups

On Tue, Nov 16, 2021 at 5:33 PM Vlastimil Babka [off-list ref] wrote:
On 11/16/21 15:02, Andrey Konovalov wrote:
quoted
quoted
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -249,7 +249,7 @@ static void print_address_description(void *addr, u8 tag)

        if (page && PageSlab(page)) {
                struct kmem_cache *cache = page->slab_cache;
-               void *object = nearest_obj(cache, page, addr);
+               void *object = nearest_obj(cache, page_slab(page),      addr);
The tab before addr should be a space. checkpatch should probably report this.
Good catch, thanks. Note the tab is there already before this patch, it just
happened to appear identical to a single space before.
Ah, indeed. Free free to keep this as is to not pollute the patch. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help