Thread (42 messages) 42 messages, 6 authors, 2021-12-08

Re: [PATCH V7 05/18] x86/pks: Add PKS setup code

From: Thomas Gleixner <hidden>
Date: 2021-11-26 10:00:19
Also in: lkml, nvdimm

On Fri, Nov 26 2021 at 11:11, taoyi ty wrote:
On 11/25/21 11:15 PM, Thomas Gleixner wrote:
quoted
quoted
+void setup_pks(void)
+{
+	if (!cpu_feature_enabled(X86_FEATURE_PKS))
+		return;
+
+	write_pkrs(pkrs_init_value);
Is the init value set up _before_ this function is invoked for the first
time?
Setting up for cpu0 is before create_initial_pkrs_value. therefore pkrs 
value of cpu0 won't be set correctly.

[root@AliYun ~]# rdmsr -a 0x000006E1
0
55555554
55555554
55555554
55555554
55555554
55555554
55555554
55555554
55555554

Here are my test results after applying the patches
Thanks for confirming what I assumed from looking at the patches!

       tglx


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help