On Wed, Aug 11, 2021 at 12:01:28PM -0700, Edgecombe, Rick P wrote:

On Tue, 2021-08-03 at 21:32 -0700, ira.weiny@intel.com wrote:

quoted

+static int param_set_pks_fault_mode(const char *val, const struct
kernel_param *kp)
+{
+       int ret = -EINVAL;
+
+       if (!sysfs_streq(val, "relaxed")) {
+               pks_fault_mode = PKS_MODE_RELAXED;
+               ret = 0;
+       } else if (!sysfs_streq(val, "strict")) {
+               pks_fault_mode = PKS_MODE_STRICT;
+               ret = 0;
+       }
+
+       return ret;
+}
+

Looks like !sysfs_streq() should be just sysfs_streq().

Indeed. Fixed.

Thanks!
Ira