Read the whole thread, 11 messages PreviousNext Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly FromJohn Hubbard <jhubbard@nvidia.com> Date2021-08-12 18:19:09 Also inlinux-fsdevel, linux-s390, lkmlReply toChristoph Hellwig, 2021-08-12 On 8/12/21 2:22 AM, Christoph Hellwig wrote:On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:quoted- if (unlikely(!try_get_page(page))) + if (unlikely(try_get_compound_head(page, 1) == NULL)) Why not a simple ! instead of the == NULL? I'll fix those up and post a v4. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks for the reviews! thanks, -- John Hubbard NVIDIA
Keyboard shortcuts hback out one level jnext message in thread / next series-diff position kprevious message in thread / previous series-diff position ldrill in Escclose help / fold thread tree ?toggle this help