Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call... | linux-mm | Ratatoskr

[PATCH v2 0/3] A few gup refactorings and documentation updates · John Hubbard <jhubbard@nvidia.com> · 2021-08-11
[PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · John Hubbard <jhubbard@nvidia.com> · 2021-08-11
Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · William Kucharski <hidden> · 2021-08-11
Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · John Hubbard <jhubbard@nvidia.com> · 2021-08-11
Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · William Kucharski <hidden> · 2021-08-12
Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · Christoph Hellwig <hch@lst.de> · 2021-08-12
Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly · John Hubbard <jhubbard@nvidia.com> · 2021-08-12
[PATCH v2 1/3] mm/gup: documentation corrections for gup/pup · John Hubbard <jhubbard@nvidia.com> · 2021-08-11
[PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() · John Hubbard <jhubbard@nvidia.com> · 2021-08-11
Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() · Christoph Hellwig <hch@lst.de> · 2021-08-12
Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() · John Hubbard <jhubbard@nvidia.com> · 2021-08-12

Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly

From: Christoph Hellwig <hch@lst.de>
Date: 2021-08-12 09:22:14
Also in: linux-fsdevel, linux-s390, lkml

On Wed, Aug 11, 2021 at 12:05:42AM -0700, John Hubbard wrote:

-		if (unlikely(!try_get_page(page)))
+		if (unlikely(try_get_compound_head(page, 1) == NULL))

Why not a simple ! instead of the == NULL?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>