Re: [PATCH 1/5] Compiler Attributes: Add __alloc_size() for better bounds checking
From: Kees Cook <hidden>
Date: 2021-08-18 17:58:47
Also in:
linux-hardening, linux-kbuild, lkml
From: Kees Cook <hidden>
Date: 2021-08-18 17:58:47
Also in:
linux-hardening, linux-kbuild, lkml
On Wed, Aug 18, 2021 at 03:07:48PM +0200, Miguel Ojeda wrote:
On Wed, Aug 18, 2021 at 7:08 AM Kees Cook [off-list ref] wrote:quoted
Clang can additionally use alloc_size to informt the results ofTypo.quoted
Additionally disables -Wno-alloc-size-larger-than since the allocatorsDisables -Walloc-size-larger-than?quoted
already reject SIZE_MAX, and the compile-time warnings aren't helpful.Perhaps a bit more context here (and/or in the comment in the Makefile) would be nice: i.e. why are they not helpful (even if rejected by the allocators).
Thanks for the review! I'll get this all fixed for v2. -- Kees Cook