Thread (76 messages) 76 messages, 8 authors, 2021-08-23

Re: [PATCH v4 35/35] mm, slub: convert kmem_cpu_slab protection to local_lock

From: Vlastimil Babka <hidden>
Date: 2021-08-17 15:42:39
Also in: lkml

On 8/17/21 5:39 PM, Sebastian Andrzej Siewior wrote:
On 2021-08-05 17:20:00 [+0200], Vlastimil Babka wrote:
quoted
@@ -2849,7 +2891,11 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node,
 
 load_freelist:
 
-	lockdep_assert_irqs_disabled();
+#ifdef CONFIG_PREEMPT_RT
+	lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock.lock));
+#else
+	lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock));
+#endif
Could you please make this hunk only

	lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock));

i.e. the non-RT version?
Does it mean that version works fine on RT now?
quoted
 	/*
 	 * freelist is pointing to the list of objects to be used.

Sebastian
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help