Thread (76 messages) 76 messages, 8 authors, 2021-08-23
STALE1761d REVIEWED: 1 (0M)
Revisions (4)
  1. v3 [diff vs current]
  2. v4 current
  3. v5 [diff vs current]
  4. v6 [diff vs current]

[PATCH v4 01/35] mm, slub: don't call flush_all() from slab_debug_trace_open()

From: Vlastimil Babka <hidden>
Date: 2021-08-05 15:20:09
Also in: lkml
Subsystem: memory management, slab allocator, the rest · Maintainers: Andrew Morton, Vlastimil Babka, Harry Yoo, Linus Torvalds

slab_debug_trace_open() can only be called on caches with SLAB_STORE_USER flag
and as with all slub debugging flags, such caches avoid cpu or percpu partial
slabs altogether, so there's nothing to flush.

Signed-off-by: Vlastimil Babka <redacted>
Acked-by: Christoph Lameter <redacted>
---
 mm/slub.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index af984e4990e8..f5908e6b6fb1 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5822,9 +5822,6 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep)
 	if (!alloc_loc_track(t, PAGE_SIZE / sizeof(struct location), GFP_KERNEL))
 		return -ENOMEM;
 
-	/* Push back cpu slabs */
-	flush_all(s);
-
 	for_each_kmem_cache_node(s, node, n) {
 		unsigned long flags;
 		struct page *page;
-- 
2.32.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help