Re: [PATCH v1 05/11] mm/sparse-vmemmap: add a pgmap argument to section activation

From
Joao Martins <hidden>
Date
2021-05-05 22:38:04
Reply to
Dan Williams, 2021-05-05

On 5/5/21 11:34 PM, Dan Williams wrote:
On Thu, Mar 25, 2021 at 4:10 PM Joao Martins [off-list ref] wrote:
quoted
@altmap is stored in a dev_pagemap, but it will be repurposed for
hotplug memory for storing the memmap in the hotplugged memory[*] and
reusing the altmap infrastructure to that end. This is to say that
altmap can't be replaced with a @pgmap as it is going to cover more than
dev_pagemap backend altmaps.
I was going to say, just pass the pgmap and lookup the altmap from
pgmap, but Oscar added a use case for altmap independent of pgmap. So
you might refresh this commit message to clarify why passing pgmap by
itself is not sufficient.
Isn't that what I am doing above with that exact paragraph? I even
reference his series at the end of commit description :) in [*]
Other than that, looks good.
/me nods
Thread (64 messages) 64 messages, 5 authors, last reply 2021-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help