Re: [PATCH 00/14] Clean W=1 build warnings for mm/

From
Vlastimil Babka <hidden>
Date
2021-05-25 11:48:35
Also in
lkml
Reply to
Mel Gorman, 2021-05-20
On 5/20/21 10:47 AM, Mel Gorman wrote:
This is a janitorial only. During development of a tool to catch build
warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/
is not clean for W=1. This is generally harmless but there is no harm in
cleaning it up. It disrupts git blame a little but on relatively obvious
lines that are unlikely to be git blame targets.

 include/asm-generic/early_ioremap.h | 9 +++++++++
 include/linux/mmzone.h              | 5 ++++-
 include/linux/swap.h                | 6 +++++-
 mm/internal.h                       | 3 +--
 mm/mapping_dirty_helpers.c          | 2 +-
 mm/memcontrol.c                     | 2 +-
 mm/memory_hotplug.c                 | 6 +++---
 mm/mmap_lock.c                      | 2 ++
 mm/page_alloc.c                     | 2 +-
 mm/vmalloc.c                        | 3 +++
 mm/vmscan.c                         | 2 +-
 mm/z3fold.c                         | 2 ++
 mm/zbud.c                           | 2 ++
 13 files changed, 35 insertions(+), 11 deletions(-)
Thanks, looks good.

patch 3/14 subject looks like it should read just "mm/page_alloc: Make
should_fail_alloc_page a static function"

Acked-by: Vlastimil Babka <redacted>


Thread (23 messages) 23 messages, 6 authors, last reply 2021-07-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help