Re: [PATCH 08/14] mm/memory_hotplug: Fix kerneldoc comment for __remove_memory

From
David Hildenbrand <hidden>
Date
2021-05-20 11:01:11
Also in
lkml
Reply to
Mel Gorman, 2021-05-20
On 20.05.21 10:48, Mel Gorman wrote:
quoted hunk ↗ jump to hunk
make W=1 generates the following warning for __remove_memory

   mm/memory_hotplug.c:2044: warning: expecting prototype for remove_memory(). Prototype was for __remove_memory() instead

Commit eca499ab3749 ("mm/hotplug: make remove_memory() interface usable")
introduced the kerneldoc comment and function but the kerneldoc name and
function name did not match.

Fixes: eca499ab3749 ("mm/hotplug: make remove_memory() interface usable")
Signed-off-by: Mel Gorman <redacted>
---
  mm/memory_hotplug.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index e3266be1d020..4ea1b19e8c7a 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -2031,7 +2031,7 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size)
  }
  
  /**
- * remove_memory
+ * __remove_memory - Remove memory if every memory block is offline
   * @nid: the node ID
   * @start: physical address of the region to remove
   * @size: size of the region to remove
Reviewed-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb

Thread (23 messages) 23 messages, 6 authors, last reply 2021-07-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help