Re: [PATCH 2/5] mm/sparse: free section usage memory in case populate_section_memmap failed
From: Mike Rapoport <rppt@kernel.org>
Date: 2021-05-18 10:09:50
Also in:
lkml
On Mon, May 17, 2021 at 07:20:41PM +0800, Dong Aisheng wrote:
quoted hunk ↗ jump to hunk
Free section usage memory in case populate_section_memmap failed. We use map_count to track the remain unused memory to be freed. Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- mm/sparse.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/mm/sparse.c b/mm/sparse.c index 7ac481353b6b..98bfacc763da 100644 --- a/mm/sparse.c +++ b/mm/sparse.c@@ -549,12 +549,14 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin, __func__, nid); pnum_begin = pnum; sparse_buffer_fini(); + memblock_free_early(__pa(usage), map_count * mem_section_usage_size());
I'd move both sparse_buffer_fini() and freeing of 'usage' memory after the failed label.
goto failed; } check_usemap_section_nr(nid, usage); sparse_init_one_section(__nr_to_section(pnum), pnum, map, usage, SECTION_IS_EARLY); usage = (void *) usage + mem_section_usage_size(); + map_count--; } sparse_buffer_fini(); return; -- 2.25.1
-- Sincerely yours, Mike.