Thread (41 messages) 41 messages, 4 authors, 2021-02-08

Re: [PATCH 1/7] mm: memcontrol: fix cpuhotplug statistics flushing

From: Shakeel Butt <hidden>
Date: 2021-02-02 22:27:28
Also in: cgroups, lkml

On Tue, Feb 2, 2021 at 12:18 PM Johannes Weiner [off-list ref] wrote:
The memcg hotunplug callback erroneously flushes counts on the local
CPU, not the counts of the CPU going away; those counts will be lost.

Flush the CPU that is actually going away.

Also simplify the code a bit by using mod_memcg_state() and
count_memcg_events() instead of open-coding the upward flush - this is
comparable to how vmstat.c handles hotunplug flushing.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
I think we need Fixes: a983b5ebee572 ("mm: memcontrol: fix excessive
complexity in memory.stat reporting")

Reviewed-by: Shakeel Butt <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help