Re: [PATCH] mm/hugetlb: Simplify the calculation of variables
From: Mike Kravetz <hidden>
Date: 2021-01-27 04:15:26
Also in:
lkml
On 1/25/21 10:44 PM, Jiapeng Zhong wrote:
Fix the following coccicheck warnings: ./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Zhong <redacted> --- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks, Reviewed-by: Mike Kravetz <redacted> -- Mike Kravetz
quoted hunk ↗ jump to hunk
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index cbf32d2..5e6a6e7 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c@@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) mpol_allowed = policy_nodemask_current(gfp_mask); for_each_node_mask(node, cpuset_current_mems_allowed) { - if (!mpol_allowed || - (mpol_allowed && node_isset(node, *mpol_allowed))) + if (!mpol_allowed || node_isset(node, *mpol_allowed)) nr += array[node]; }