Thread (3 messages) 3 messages, 3 authors, 2021-01-27

Re: [PATCH] mm/hugetlb: Simplify the calculation of variables

From: Miaohe Lin <linmiaohe@huawei.com>
Date: 2021-01-26 18:39:13
Also in: lkml

Hi:
On 2021/1/26 14:44, Jiapeng Zhong wrote:
quoted hunk ↗ jump to hunk
Fix the following coccicheck warnings:

./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to
!A || B.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Zhong <redacted>
---
 mm/hugetlb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index cbf32d2..5e6a6e7 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h)
 	mpol_allowed = policy_nodemask_current(gfp_mask);
 
 	for_each_node_mask(node, cpuset_current_mems_allowed) {
-		if (!mpol_allowed ||
-		    (mpol_allowed && node_isset(node, *mpol_allowed)))
+		if (!mpol_allowed || node_isset(node, *mpol_allowed))
 			nr += array[node];
 	}
 
I'm gonna do this too. :)

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help