Re: [PATCH v2 01/10] mm: use add_page_to_lru_list()
From: Vlastimil Babka <hidden>
Date: 2021-01-27 01:51:47
Also in:
lkml
On 1/22/21 11:05 PM, Yu Zhao wrote:
There is add_page_to_lru_list(), and move_pages_to_lru() should reuse it, not duplicate it. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-2-yuzhao@google.com/ (local) Signed-off-by: Yu Zhao <redacted> Reviewed-by: Alex Shi <redacted>
Acked-by: Vlastimil Babka <redacted>
quoted hunk ↗ jump to hunk
--- mm/vmscan.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)diff --git a/mm/vmscan.c b/mm/vmscan.c index 04509994aed4..19875660e8f8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c@@ -1823,7 +1823,6 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, int nr_pages, nr_moved = 0; LIST_HEAD(pages_to_free); struct page *page; - enum lru_list lru; while (!list_empty(list)) { page = lru_to_page(list);@@ -1868,11 +1867,8 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, * inhibits memcg migration). */ VM_BUG_ON_PAGE(!lruvec_holds_page_lru_lock(page, lruvec), page); - lru = page_lru(page); + add_page_to_lru_list(page, lruvec, page_lru(page)); nr_pages = thp_nr_pages(page); - - update_lru_size(lruvec, lru, page_zonenum(page), nr_pages); - list_add(&page->lru, &lruvec->lists[lru]); nr_moved += nr_pages; if (PageActive(page)) workingset_age_nonresident(lruvec, nr_pages);