Thread (19 messages) 19 messages, 5 authors, 2021-01-15

Re: [RFC PATCH 2/3] hugetlb: convert page_huge_active() to HPageMigratable flag

From: Oscar Salvador <osalvador@suse.de>
Date: 2021-01-15 20:30:31
Also in: lkml

On Fri, Jan 15, 2021 at 12:05:29PM -0800, Mike Kravetz wrote:
I went back and took a closer look.  Migration is the reason the existing
page_huge_active interfaces were introduced.  And, the only use of the
page_huge_active check is to determine if a page can be migrated.  So,
I think 'Migratable' may be the most suitable name.
Ok, I did not know that. Let us stick with 'Migratable' then.
To address the concern about not all hugetlb sizes are migratable, we can
just make a check before setting the flag.  This should even help in the
migration/offline paths as we will know sooner if the page can be
migrated or not.
This sounds like a good idea to me.
We can address naming in the 'migrating free hugetlb pages' issue when
that code is written.
Sure, it was just a suggestion as when I though about that something
like 'InUse' or 'Active' made more sense to me, but your point is valid.

Sorry for the confusion.

About that alloc_contig_range topic, I would like to take a look unless
someone is already on it or about to be.

Thanks Mike for the time ;-)


-- 
Oscar Salvador
SUSE L3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help