On 1/12/2021 5:52 PM, Matthew Wilcox wrote:

On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote:

quoted

@@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s)
 
 struct slab_attribute {
 	struct attribute attr;
+	struct bin_attribute bin_attr;
 	ssize_t (*show)(struct kmem_cache *s, char *buf);
 	ssize_t (*store)(struct kmem_cache *s, const char *x, size_t count);
 };

I'd rather you added a struct slab_bin_attribute.  If that's even
needed ..  I think you could just use the bin_attribute directly instead
of embedding it in this struct.

Okay, I will use bin_attribute directly, but I added the bin_attribute
inside the slab_attribute to maintain similar code like sysfs attribute
and slab_attribute is embedded with it's all slab attributes.