Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-01-12 12:24:27
Also in:
lkml
On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote:
quoted hunk ↗ jump to hunk
@@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s) struct slab_attribute { struct attribute attr; + struct bin_attribute bin_attr; ssize_t (*show)(struct kmem_cache *s, char *buf); ssize_t (*store)(struct kmem_cache *s, const char *x, size_t count); };
I'd rather you added a struct slab_bin_attribute. If that's even needed .. I think you could just use the bin_attribute directly instead of embedding it in this struct.