Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

2017.10.12  05:42 AM  Russell King - ARM Linux [mailto:linux@armlinux.org.uk] wrote:

quoted

Please don't make this "exclusive" just conditionally call 
kasan_early_init(), remove the call to start_kernel from 
kasan_early_init and keep the call to start_kernel here.

iow:

#ifdef CONFIG_KASAN
bl	kasan_early_init
#endif
b	start_kernel

This has the advantage that we don't leave any stack frame from
kasan_early_init() on the init task stack.

Thanks for your review.  I tested your opinion and it work well.
I agree with you that it is better to use follow code
#ifdef CONFIG_KASAN
	bl	kasan_early_init
#endif
	b	start_kernel

than :
#ifdef CONFIG_KASAN
	bl	kasan_early_init
#else
	b	start_kernel
#endif




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>